Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix mentions rendering in comment editor #35322

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 22, 2022

Manual backport of #35187

@artonge artonge added this to the Nextcloud 25.0.2 milestone Nov 22, 2022
@artonge artonge self-assigned this Nov 22, 2022
@artonge artonge marked this pull request as ready for review November 22, 2022 10:04
@artonge artonge changed the title Fix mentions rendering in comment editor [stable25] Fix mentions rendering in comment editor Nov 22, 2022
@blizzz blizzz mentioned this pull request Nov 22, 2022
1 task
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

NcRichContentEditable needs an index of users to properly display them. This commit adds a caching logic and provides it to NcRichContentEditable.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@blizzz blizzz disabled auto-merge November 23, 2022 16:59
@blizzz blizzz merged commit 695ceba into stable25 Nov 23, 2022
@blizzz blizzz deleted the backport/stable25/35187 branch November 23, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants